linux-kernel - Re: BUG: "iommu: Retire bus ops" breaks omap-iommu and omap3isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241007183153.6daa419d@akair>
Date: Mon, 7 Oct 2024 18:31:53 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: "H. Nikolaus Schaller" <hns@...delico.com>, Robin Murphy
 <robin.murphy@....com>, Laurent Pinchart
 <laurent.pinchart@...asonboard.com>, "Rafael J. Wysocki"
 <rafael.j.wysocki@...el.com>, Christoph Hellwig <hch@....de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Lu Baolu
 <baolu.lu@...ux.intel.com>, Jerry Snitselaar <jsnitsel@...hat.com>, Joerg
 Roedel <jroedel@...e.de>, tony Lindgren <tony@...mide.com>, Linux-OMAP
 <linux-omap@...r.kernel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org
Subject: Re: BUG: "iommu: Retire bus ops" breaks omap-iommu and omap3isp

Am Mon, 7 Oct 2024 11:48:24 -0300
schrieb Jason Gunthorpe <jgg@...dia.com>:

> On Mon, Oct 07, 2024 at 04:01:17PM +0200, Andreas Kemnade wrote:
> > > @@ -1233,6 +1233,12 @@ static int omap_iommu_probe(struct
> > > platform_device *pdev) err = iommu_device_register(&obj->iommu,
> > > &omap_iommu_ops, &pdev->dev); if (err)
> > >                         goto out_sysfs;
> > > +               /*
> > > +                * omap has a DT reprensetation but can't use the
> > > common DT
> > > +                * code. Setting fwnode to NULL causes probe to be
> > > called for
> > > +                * every device.
> > > +                */
> > > +               obj->iommu.fwnode = NULL;
> > >                 obj->has_iommu_driver = true;
> > >         }
> > >   
> > hmm, that looks nice for a regression fix.
> > 
> > Does it make sense to adopt dt so that the common code can be used
> > to ease future maintenance?  
> 
> It would be nice, but I recall omap doesn't use the standard dt
> layout?
> 
that is what is said in the comment. But what is missing? Is it one or
two properties at one place, or is it turing everything upside-down?

Regards,
Andreas