linux-kernel - Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPj87rPGD8Pu_CSPXfRtsS_w8UYVJGR9CoLx7RAT69EUKefs3A@mail.gmail.com>
Date: Mon, 7 Oct 2024 12:37:39 -0400
From: Daniel Stone <daniel@...ishbar.org>
To: Vignesh Raman <vignesh.raman@...labora.com>
Cc: dri-devel@...ts.freedesktop.org, daniels@...labora.com, 
	helen.koike@...labora.com, airlied@...il.com, daniel@...ll.ch, 
	robdclark@...il.com, guilherme.gallo@...labora.com, 
	sergi.blanch.torne@...labora.com, deborah.brouwer@...labora.com, 
	dmitry.baryshkov@...aro.org, linux-arm-msm@...r.kernel.org, 
	intel-gfx@...ts.freedesktop.org, virtualization@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

Hi Vignesh,

On Fri, 4 Oct 2024 at 09:31, Vignesh Raman <vignesh.raman@...labora.com> wrote:
> +.software-driver:
> +  stage: software-driver
> +  extends:
> +    - .test-gl
> +    - .test-rules
> +  timeout: "1h30m"
> +  tags:
> +    - kvm
> +  script:
> +    - ln -sf $CI_PROJECT_DIR/install /install
> +    - mv install/bzImage /lava-files/bzImage
> +    - mkdir -p /lib/modules
> +    - mkdir -p $CI_PROJECT_DIR/results
> +    - ln -sf $CI_PROJECT_DIR/results /results
> +    - install/crosvm-runner.sh install/igt_runner.sh

Instead of inlining this here, can we please move towards reusing more
of .gitlab-ci/common/init-stage[12].sh? If those files need to be
modified then that's totally fine, but I'd rather have something more
predictable, and fewer random pieces of shell in each job section.