linux-kernel - Re: [PATCH v2] selftests: sched_ext: Add sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87msjfn9oz.fsf@all.your.base.are.belong.to.us>
Date: Mon, 07 Oct 2024 18:45:32 +0200
From: Björn Töpel <bjorn@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Tejun Heo <tj@...nel.org>, David Vernet <void@...ifault.com>, Shuah Khan
 <shuah@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Björn Töpel
 <bjorn@...osinc.com>,
 bpf@...r.kernel.org, linux-riscv@...ts.infradead.org, Anders Roxell
 <anders.roxell@...aro.org>
Subject: Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper
 selftest target

Mark Brown <broonie@...nel.org> writes:

> On Mon, Oct 07, 2024 at 06:00:57PM +0200, Björn Töpel wrote:
>> Mark Brown <broonie@...nel.org> writes:
>> > On Mon, Oct 07, 2024 at 09:31:32AM +0200, Björn Töpel wrote:
>
>> >   CLNG-BPF create_dsq.bpf.o
>> > In file included from create_dsq.bpf.c:9:
>> > /home/broonie/git/linux/tools/sched_ext/include/scx/common.bpf.h:33:17: error: use of undeclared identifier 'SCX_DSQ_FLAG_BUILTIN'
>> >    33 |         _Static_assert(SCX_DSQ_FLAG_BUILTIN,
>> >       |                        ^
>
>> This is most likely due to incorrect VMLINUX_BTF_PATHS, so that
>> vmlinux.h is incorrectly generated. Try grepping for
>> SCX_DSQ_FLAG_BUILTIN in vmlinux.h.
>
> Yeah, it's not in the generated files:
>
> broonie@...isterre:~/git/linux$ grep SCX_DSQ_FLAG_BUILTIN ./tools/testing/selftests/sched_ext/build/include/vmlinux.h ./tools/testing/selftests/sched_ext/build/obj/bpftool/vmlinux.h
> broonie@...isterre:~/git/linux$ 
>
> I didn't actually build a kernel, if the build system needs a kernel
> it's just silently not detected that it's missing?

It tries to find a kernel with BTF:
  | VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux)                                    \
  |                      $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux)            \
  |                      ../../../../vmlinux                                        \
  |                      /sys/kernel/btf/vmlinux                                    \
  |                      /boot/vmlinux-$(shell uname -r)

Similar to all the other selftests using BPF.

(Oh, and at some point the BPF parts should be in lib.mk...)


Björn