linux-kernel - Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <deeflg5wd756tkfr6zdta4imuc7ijwl56yclfwiqexlqdq6jsk@5za5g6i7wj6k>
Date: Mon, 7 Oct 2024 08:07:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote:
> +  ti,davinci-nand-use-bbt:
> +    type: boolean
> +    description:
> +      Use flash based bad block table support. OOB identifier is saved in OOB
> +      area.
> +    deprecated: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - ti,davinci-chipselect
> +
> +additionalProperties: true

That's a final device schema, this cannot be true. Why you are doing
this entirely different than all other bindings?

You wrote in changelog, that you "silent the errors". Sorry, but that's
a no go. You are not suppose to silent them, but FIX THEM.


> +
> +examples:
> +  - |
> +    nand-controller@...0000 {
> +      compatible = "ti,davinci-nand";
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      reg = <0 0x02000000>;

Keep order like in DTS coding style.

Best regards,
Krzysztof