linux-kernel - Re: [PATCH 2/8] ACPI: battery: Register power supply with power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j=P9orUe9k0bsUfxE0YA8stsbAi=k+ge4_XBeuHVnyrw@mail.gmail.com>
Date: Mon, 7 Oct 2024 18:51:45 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Sebastian Reichel <sre@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Pali Rohár <pali@...nel.org>, 
	Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>, 
	Luca Ceresoli <luca.ceresoli@...tlin.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, 
	chrome-platform@...ts.linux.dev
Subject: Re: [PATCH 2/8] ACPI: battery: Register power supply with power_supply_register()

On Sat, Oct 5, 2024 at 12:05 PM Thomas Weißschuh <linux@...ssschuh.net> wrote:
>
> power_supply_register_no_ws() is going to be removed.
> Switch to the general registration API.
>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...e;.com>

and I'm assuming this to be handled along with the rest of the series.

> ---
>  drivers/acpi/battery.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 65fa3444367a13ac83644444076a11f08152c382..9a3a475f8ad334bb365e6a0273084034b8baa3bd 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -853,6 +853,7 @@ static int sysfs_add_battery(struct acpi_battery *battery)
>         struct power_supply_config psy_cfg = {
>                 .drv_data = battery,
>                 .attr_grp = acpi_battery_groups,
> +               .no_wakeup_source = true,
>         };
>         bool full_cap_broken = false;
>
> @@ -888,7 +889,7 @@ static int sysfs_add_battery(struct acpi_battery *battery)
>         battery->bat_desc.type = POWER_SUPPLY_TYPE_BATTERY;
>         battery->bat_desc.get_property = acpi_battery_get_property;
>
> -       battery->bat = power_supply_register_no_ws(&battery->device->dev,
> +       battery->bat = power_supply_register(&battery->device->dev,
>                                 &battery->bat_desc, &psy_cfg);
>
>         if (IS_ERR(battery->bat)) {
>
> --
> 2.46.2
>