linux-kernel - Re: [PATCH v1] asm-generic: introduce be56 unaligned accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <43cee6a3-ce29-402d-978e-a8251d08c522@app.fastmail.com>
Date: Mon, 07 Oct 2024 17:08:52 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Marius.Cristea" <Marius.Cristea@...rochip.com>,
 "David Laight" <David.Laight@...lab.com>
Cc: Linux-Arch <linux-arch@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] asm-generic: introduce be56 unaligned accessors

On Mon, Oct 7, 2024, at 14:57, Marius.Cristea@...rochip.com wrote:
> On Mon, 2024-10-07 at 14:44 +0000, Arnd Bergmann wrote:
>
> Most probably this request is quite specific to my driver and I'm not
> sure how often it will be used by somebody else.
>
> I'm using block read in order to get multiple registers at a time
> (around 76 bytes) and to increase the efficiency of the transfer over
> I2C. Being a block read there are different registers length involved
> from 16 up to 56 bits long and I need to unpack.

Ok, makes sense. In this case I would keep the exact implementation
you have but move it into your driver where I guess it started out.
If we ever get multiple drivers that need the same thing, we can
still consolidate the implementation.

       Arnd