[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241007172006.83339-1-prosunofficial@gmail.com>
Date: Mon, 7 Oct 2024 22:50:06 +0530
From: R Sundar <prosunofficial@...il.com>
To: tytso@....edu,
adilger.kernel@...ger.ca
Cc: linux-ext4@...r.kernel.org,
linux-kernel@...r.kernel.org,
riteshh@...ux.ibm.com,
R Sundar <prosunofficial@...il.com>,
kernel test robot <lkp@...el.com>,
Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH linux-next] ext4: use string choices helpers
Use string choice helpers for better readability and to fix cocci warning
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...ia.fr>
Closes: https://lore.kernel.org/r/202410062256.BoynX3c2-lkp@intel.com/
Signed-off-by: R Sundar <prosunofficial@...il.com>
---
Reported in linux repo:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
cocci warnings: (new ones prefixed by >>)
>> fs/ext4/mballoc.c:4597:47-50: opportunity for str_yes_no(ret)
vim +4597 fs/ext4/mballoc.c
compile tested only.
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index d73e38323879..49dd27c2f2dc 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb,
}
out_dbg:
- mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no");
+ mb_debug(sb, "freed %d, retry ? %s\n", freed, str_yes_no(ret));
return ret;
}
--
2.34.1
Powered by blists - more mailing lists