linux-kernel - Re: [PATCH net] net: ethernet: adi: adin1110: Fix some error handling path in adin1110_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78da956-955d-adbf-cf21-6c56d1d7853@inria.fr>
Date: Mon, 7 Oct 2024 19:35:31 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Simon Horman <horms@...nel.org>
cc: Jakub Kicinski <kuba@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>, 
    Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
    Lennart Franzen <lennart@...omain.com>, 
    Alexandru Tachici <alexandru.tachici@...log.com>, 
    linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, 
    netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: adi: adin1110: Fix some error handling
 path in adin1110_read_fifo()



On Mon, 7 Oct 2024, Simon Horman wrote:

> On Fri, Oct 04, 2024 at 11:09:52AM -0700, Jakub Kicinski wrote:
> > On Fri, 4 Oct 2024 14:47:22 +0300 Dan Carpenter wrote:
> > > It's a pity that deliberately doing a "return ret;" when ret is zero is so
> > > common.  Someone explained to me that it was "done deliberately to express that
> > > we were propagating the success from frob_whatever()".  No no no!
> >
> > FWIW I pitched to Linus that we should have a err_t of some sort for
> > int variables which must never be returned with value of 0.
> > He wasn't impressed, but I still think it would be useful :)
>
> FWIIW, I think something like that would be quite nice.

Likewise.

julia