linux-kernel - Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a36f0fec7c007031f55e220a0ca585b48630f205.camel@sipsolutions.net>
Date: Mon, 07 Oct 2024 20:03:22 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Kalle Valo <kvalo@...nel.org>, Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 linux-kernel@...r.kernel.org,  linux-wireless@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless
 files from NETWORKING [GENERAL]

On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote:
> Simon Horman <horms@...nel.org> writes:
> 
> > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > 
> > > Simon Horman <horms@...nel.org> writes:
> > > 
> > > > We already exclude wireless drivers from the netdev@ traffic, to
> > > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > > 
> > > > Many of the following wireless-related sections MAINTAINERS
> > > > are already not included in the NETWORKING [GENERAL] section.
> > > > For consistency, exclude those that are.
> > > > 
> > > > * 802.11 (including CFG80211/NL80211)
> > > > * MAC80211
> > > > * RFKILL
> > > > 
> > > > Signed-off-by: Simon Horman <horms@...nel.org>
> > > > ---
> > > >  MAINTAINERS | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > > >  F:	net/
> > > >  F:	tools/net/
> > > >  F:	tools/testing/selftests/net/
> > > > +X:	Documentation/networking/mac80211-injection.rst
> > > > +X:	Documentation/networking/mac80211_hwsim/
> > > > +X:	Documentation/networking/regulatory.rst
> > > > +X:	include/net/cfg80211.h
> > > > +X:	include/net/ieee80211_radiotap.h
> > > > +X:	include/net/iw_handler.h
> > > > +X:	include/net/mac80211.h
> > > > +X:	include/net/wext.h
> > > 
> > > Should we add also lib80211.h?
> > 
> > Thanks, I missed that one. Perhaps it should have:
> > 
> > * An F: entry in the MAC80211
> > * An X: entry in the NETWORKING [GENERAL]
> > 
> > If so, perhaps I can just add that to a v2 of this patch.
> > Let me know what you think.
> 
> Like Johannes said, the cfg80211 entry is more approriate but otherwise
> sounds like a good plan, thanks!

Actually scratch that, please just ignore it. I'm going to remove that
header file entirely and move the functionality into libipw in the
ipw2x00 drivers.

johannes