linux-kernel - Re: [PATCH] scripts/decode_stacktrace.sh: remove trailing space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwQ2l8zo6BZQnnkB@google.com>
Date: Mon, 7 Oct 2024 19:29:27 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Breno Leitao <leitao@...ian.org>
Cc: akpm@...ux-foundation.org, Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Stephen Boyd <swboyd@...omium.org>,
	Elliot Berman <quic_eberman@...cinc.com>,
	Xiong Nandi <xndchn@...il.com>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	Bjorn Andersson <quic_bjorande@...cinc.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/decode_stacktrace.sh: remove trailing space

On Thu, Oct 03, 2024 at 03:30:05AM -0700, Breno Leitao wrote:
> decode_stacktrace.sh adds a trailing space at the end of the decoded
> stack if the module is not set (in most of the lines), which makes the
> some lines of the stack having trailing space and some others not.
> 
> Do not add an extra space at the end of the line if module is not set,
> adding consistency in output formatting.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  scripts/decode_stacktrace.sh | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index 826836d264c6..4b3502a007fd 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -311,7 +311,12 @@ handle_line() {
>  	parse_symbol # modifies $symbol
>  
>  	# Add up the line number to the symbol
> -	echo "${words[@]}" "$symbol $module"
> +	if [ -z ${module} ]
> +	then

nit: it seems the convention would have been something like:
	if [[ -z $module ]]; then

> +		echo "${words[@]}" "$symbol"
> +	else
> +		echo "${words[@]}" "$symbol $module"

I guess the space could have also been prepended in module above? e.g
	module=" $module"

> +	fi
>  }
>  
>  while read line; do
> -- 
> 2.43.5
> 

...either way this looks good to me.

Reviewed-by: Carlos Llamas <cmllamas@...gle.com>