linux-kernel - Re: [PATCH 3/3] spi: spi-mem: Add Realtek SPI-NAND controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a39e9fc8-b580-4324-8ba0-63a1a51685e9@alliedtelesis.co.nz>
Date: Tue, 8 Oct 2024 08:35:03 +1300
From: Chris Packham <chris.packham@...iedtelesis.co.nz>
To: Mark Brown <broonie@...nel.org>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 tsbogend@...ha.franken.de, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org
Subject: Re: [PATCH 3/3] spi: spi-mem: Add Realtek SPI-NAND controller


On 8/10/24 03:42, Mark Brown wrote:
> On Mon, Oct 07, 2024 at 12:33:47PM +1300, Chris Packham wrote:
>
>> +REALTEK SPI-NAND
>> +M:	Chris Pacham <chris.packham@...iedtelesis.co.nz>
> Pacham?
Darn, that'll teach me for hurriedly going through the checkpatch warnings.
>
>> +static int rtl_snand_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
>> +{
>> +	return 0;
>> +}
>> +
> If the framework doesn't already support this callback being missing we
> should probably make it so.
The framework handles this being missing. This is just left over from 
the initial stub I created when I started. Will remove in v2.
>
> Otherwise this looks good.