[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <172833174920.2317928.5857318488649665401.robh@kernel.org>
Date: Mon, 7 Oct 2024 15:09:13 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
imx@...ts.linux.dev, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl,ls-extirq:
workaround wrong interrupt-map number
On Mon, 07 Oct 2024 12:18:23 -0400, Frank Li wrote:
> The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT
> function to parser interrupt-map. So it doesn't consider '#address-size'
> in parent interrupt controller, such as GIC.
>
> When dt-binding verify interrupt-map, item data matrix is spitted at
> incorrect position. So cause below warning:
>
> arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: interrupt-controller@14:
> interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], ...
> is too short
>
> Remove interrupt-map restriction to workaround this warning for
> 'fsl,ls1088a-extirq', 'fsl,ls2080a-extirq' and fsl,lx2160a-extirq.
> Other keep the same restriction.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Change from v2 to v3
> - remove interrupt-map restriction according rob's suggestion.
> Change from v1 to v2
> - remove duplicate function in commit message
> - only reduce miniItems for after 1088a chips
> - maxItems change to 9. Otherwise report too long.
> ---
> .../interrupt-controller/fsl,ls-extirq.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
Applied, thanks!
Powered by blists - more mailing lists