linux-kernel - Re: [PATCH V2] block: Fix elevator_get_default() to check for null q->tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c310f0e-b677-4731-b827-df14b197545a@kernel.dk>
Date: Mon, 7 Oct 2024 14:24:19 -0600
From: Jens Axboe <axboe@...nel.dk>
To: SurajSonawane2415 <surajsonawane0215@...il.com>
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 hch@...radead.org
Subject: Re: [PATCH V2] block: Fix elevator_get_default() to check for null
 q->tag_set

On 10/7/24 5:14 AM, SurajSonawane2415 wrote:
> Fix error "block/elevator.c:569 elevator_get_default() error:
> we previously assumed 'q->tag_set' could be null (see line 565)".
> Since 'q->tag_set' cannot be NULL for blk-mq queues,
> remove the unnecessary check in both `elevator_get_default`
> and `elv_support_iosched`. This simplifies the logic and
> ensures correct assumptions about 'q->tag_set' in blk-mq queues.

For future patches:

1) Wrap at 72 characters, your commit message is using shorter line
   lengths.

2) Don't both with file numbers, they change all of the time. Digging
   out an old commit with line numbers isn't very useful, you'd have to
   rewind your tree for them to make sense.

I'll commit this, but rewrite the commit message somewhat.

-- 
Jens Axboe