linux-kernel - Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4934483.GXAFRqVoOG@diego>
Date: Mon, 07 Oct 2024 22:52:55 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Pavel Machek <pavel@....cz>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger

Am Montag, 7. Oktober 2024, 20:01:27 CEST schrieb Pavel Machek:
> On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> > Document the "rc-feedback" trigger which is used to control LEDs by
> > remote control device activity. This is an existing trigger used in
> > existing DTs, document it so validation of those DTs would pass.
> > 
> > It was originally introduced into the Linux kernel in 2013 with
> > commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
> 
> > index bf9a101e4d42..32f9116e03a2 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -119,6 +119,8 @@ properties:
> >              # if trigger is absent
> >            - none
> >              # LED indicates camera torch state
> > +          - rc-feedback
> > +            # LED indicates remote control feedback
> >            - torch
> >              # LED indicates USB gadget activity
> >            - usb-gadget
> 
> NAK. Wrongly placed comment.

you're right, and it even messed up the torch comment + entry
Will send a v2

Heiko