linux-kernel - Re: [PATCH] net: explicitly clear the sk pointer, when pf->create fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172834443426.18821.6784989888047565340.git-patchwork-notify@kernel.org>
Date: Mon, 07 Oct 2024 23:40:34 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Ignat Korchagin <ignat@...udflare.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-team@...udflare.com, kuniyu@...zon.com, alibuda@...ux.alibaba.com,
 stable@...r.kernel.org
Subject: Re: [PATCH] net: explicitly clear the sk pointer, when pf->create fails

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu,  3 Oct 2024 18:01:51 +0100 you wrote:
> We have recently noticed the exact same KASAN splat as in commit
> 6cd4a78d962b ("net: do not leave a dangling sk pointer, when socket
> creation fails"). The problem is that commit did not fully address the
> problem, as some pf->create implementations do not use sk_common_release
> in their error paths.
> 
> For example, we can use the same reproducer as in the above commit, but
> changing ping to arping. arping uses AF_PACKET socket and if packet_create
> fails, it will just sk_free the allocated sk object.
> 
> [...]

Here is the summary with links:
  - net: explicitly clear the sk pointer, when pf->create fails
    https://git.kernel.org/netdev/net/c/631083143315

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html