linux-kernel - [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241007065307.4158-1-aha310510@gmail.com>
Date: Mon,  7 Oct 2024 15:53:07 +0900
From: Jeongjun Park <aha310510@...il.com>
To: akpm@...ux-foundation.org
Cc: usama.anjum@...labora.com,
	peterx@...hat.com,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org,
	Jeongjun Park <aha310510@...il.com>
Subject: [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis

Looking at the source code links for mm/memory.c in the sample reports 
in the syzbot report links [1].

it looks like the line numbers are designated as lines that have been 
increased by 1. This may seem like a problem with syzkaller or the 
addr2line program that assigns the line numbers, but there is no problem 
with either of them.

In the previous commit d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC"), 
when modifying mm/memory.c, an unknown line break is added to the very first 
line of the file. However, the git.kernel.org site displays the source code 
with the added line break removed, so even though addr2line has assigned 
the correct line number, it looks like the line number has increased by 1.

This may seem like a trivial thing, but I think it would be appropriate 
to remove all the newline characters added to the upstream and stable 
versions, as they are not only incorrect in terms of code style but also 
hinder bug analysis.

[1]

https://syzkaller.appspot.com/bug?extid=4145b11cdf925264bff4
https://syzkaller.appspot.com/bug?extid=fa43f1b63e3aa6f66329
https://syzkaller.appspot.com/bug?extid=890a1df7294175947697

Fixes: d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC")
Cc: stable@...r.kernel.org
Signed-off-by: Jeongjun Park <aha310510@...il.com>
---
 mm/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index 2366578015ad..7dffe8749014 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1,4 +1,3 @@
-
 // SPDX-License-Identifier: GPL-2.0-only
 /*
  *  linux/mm/memory.c
--