linux-kernel - Re: [PATCH v4 2/2] iio: light: opt3001: add support for TI's opt3002 light sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b40d22b5bdf487b40207e676d35a0507c47cbb26.camel@axis.com>
Date: Mon, 7 Oct 2024 07:19:06 +0000
From: Emil Gedenryd <Emil.Gedenryd@...s.com>
To: "jic23@...nel.org" <jic23@...nel.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "robh@...nel.org"
	<robh@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "dannenberg@...com" <dannenberg@...com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "lars@...afoo.de"
	<lars@...afoo.de>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Kernel
	<Kernel@...s.com>
Subject: Re: [PATCH v4 2/2] iio: light: opt3001: add support for TI's opt3002
 light sensor

On Sun, 2024-10-06 at 14:16 +0100, Jonathan Cameron wrote:
> On Thu, 3 Oct 2024 14:22:17 +0200
> Emil Gedenryd <emil.gedenryd@...s.com> wrote:
> > 
> > +struct opt3001_chip_info {
> > +	const struct iio_chan_spec (*channels)[2];
> > +	enum iio_chan_type chan_type;
> > +	int num_channels;
> > +
> > +	const struct opt3001_scale (*scales)[12];
> This doesn't compile for me as one of the two options only
> has 11 entries.  You could either force them to be 12
> entries each or use a pointer without the size and
> add a num_scales entry in here.
> 
> Jonathan

Hi Jonathan,

Are you building on top of the patch that was accepted in earlier versions of this
patch set? That patch adds the twelfth missing scale value for the opt3001.
See: https://lore.kernel.org/all/20240916-add_opt3002-v3-1-984b190cd68c@axis.com/

Should I have added some tag to highlight the dependency for this version of the
patch set?

Best regards,
Emil