linux-kernel - Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D4PERKZ4GL6B.1WKA1I3MYSQVL@kernel.org>
Date: Mon, 07 Oct 2024 09:50:39 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Marc Kleine-Budde" <mkl@...gutronix.de>, "Peng Fan (OSS)"
 <peng.fan@....nxp.com>
Cc: "Rob Herring" <robh@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 "Fabio Estevam" <festevam@...il.com>, "Vignesh Raghavendra"
 <vigneshr@...com>, <devicetree@...r.kernel.org>, <imx@...ts.linux.dev>,
 "Richard Weinberger" <richard@....at>, "Sascha Hauer"
 <s.hauer@...gutronix.de>, "Marco Felsch" <m.felsch@...gutronix.de>,
 <linux-kernel@...r.kernel.org>, "Tudor Ambarus" <tudor.ambarus@...aro.org>,
 <linux-mtd@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
 "Pengutronix Kernel Team" <kernel@...gutronix.de>, "Miquel Raynal"
 <miquel.raynal@...tlin.com>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Shawn Guo" <shawnguo@...nel.org>, "Peng Fan" <peng.fan@....com>, "Pratyush
 Yadav" <pratyush@...nel.org>
Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator

Hi,

> > > +	ret = devm_regulator_get_enable(dev, "vcc");
> > > +	if (ret)
> > > +		return ret;
> > > +
> > 
> > What happens if the SPI-NOR doesn't have a "vcc" regulator?
>
> ...the SPI-NOR will use the dummy regulator.

Which then prints a warning "using dummy regulator". Is that the
usual way to go?
I mean the regulator is actually mandatory because it is the main
voltage rail for the flash. To get rid of the warning one can add a
fixed-regulator (which is correct anyway). But OTOH, the device tree
lists it as optional (marking it as required isn't an option either
because virtually all device trees won't have that property).

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)