linux-kernel - Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241007103114.1a63e3e2@xps-13>
Date: Mon, 7 Oct 2024 10:31:14 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Richard Weinberger
 <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

Hi Marcus,

marcus.folkesson@...il.com wrote on Mon, 7 Oct 2024 08:29:44 +0200:

> On Mon, Oct 07, 2024 at 08:07:27AM +0200, Krzysztof Kozlowski wrote:
> > On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote:  
> > > +  ti,davinci-nand-use-bbt:
> > > +    type: boolean
> > > +    description:
> > > +      Use flash based bad block table support. OOB identifier is saved in OOB
> > > +      area.
> > > +    deprecated: true
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - ti,davinci-chipselect
> > > +
> > > +additionalProperties: true  
> > 
> > That's a final device schema, this cannot be true. Why you are doing
> > this entirely different than all other bindings?  
> 
> From my understanding, additionalProperties is to indicate that the
> schema could contain properties that were not explicit listed here but
> inherited from e.g. nand-controller.yaml.

additionalProperties: true means there is no control over the
properties allowed, so we generally don't want that (unless you're
writing specific "generic" bindings, which is not the case here).

You are describing a controller so here you should reference to
nand-controller.yaml, but then prevent any property not defined in
nand-controller.yaml from being used. In this case you probably want to
try unevaluatedProperties: false, which means that any property not
listed here or in the referenced schemas will be prohibited.

Thanks,
Miquèl