linux-kernel - RE: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc and hsi0/1 clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00a601db1894$6a074790$3e15d6b0$@samsung.com>
Date: Mon, 7 Oct 2024 17:39:24 +0900
From: "sunyeal.hong" <sunyeal.hong@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, "'Krzysztof Kozlowski'"
	<krzk+dt@...nel.org>, "'Rob Herring'" <robh@...nel.org>, "'Conor Dooley'"
	<conor+dt@...nel.org>, "'Alim Akhtar'" <alim.akhtar@...sung.com>,
	"'Sylwester	Nawrocki'" <s.nawrocki@...sung.com>, "'Chanwoo Choi'"
	<cw00.choi@...sung.com>, "'Michael Turquette'" <mturquette@...libre.com>,
	"'Stephen Boyd'" <sboyd@...nel.org>
Cc: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-clk@...r.kernel.org>
Subject: RE: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc and
 hsi0/1 clock support

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, October 7, 2024 5:07 PM
> To: sunyeal.hong <sunyeal.hong@...sung.com>; 'Krzysztof Kozlowski'
> <krzk+dt@...nel.org>; 'Rob Herring' <robh@...nel.org>; 'Conor Dooley'
> <conor+dt@...nel.org>; 'Alim Akhtar' <alim.akhtar@...sung.com>; 'Sylwester
> Nawrocki' <s.nawrocki@...sung.com>; 'Chanwoo Choi' <cw00.choi@...sung.com>;
> 'Michael Turquette' <mturquette@...libre.com>; 'Stephen Boyd'
> <sboyd@...nel.org>
> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> clk@...r.kernel.org
> Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc
> and hsi0/1 clock support
> 
> On 07/10/2024 10:04, sunyeal.hong wrote:
> > Hello Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@...nel.org>
> >> Sent: Monday, September 30, 2024 8:36 PM
> >> To: Sunyeal Hong <sunyeal.hong@...sung.com>; Krzysztof Kozlowski
> >> <krzk+dt@...nel.org>; Rob Herring <robh@...nel.org>; Conor Dooley
> >> <conor+dt@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>;
> >> Sylwester Nawrocki <s.nawrocki@...sung.com>; Chanwoo Choi
> >> <cw00.choi@...sung.com>; Michael Turquette <mturquette@...libre.com>;
> >> Stephen Boyd <sboyd@...nel.org>
> >> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> >> linux-samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org;
> >> linux- clk@...r.kernel.org
> >> Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1,
> >> misc and hsi0/1 clock support
> >>
> >> On 12/09/2024 12:38, Sunyeal Hong wrote:
> >>> Like CMU_PERIC1, this provides clocks for USI09 ~ USI17, USI_I2C and
> >> USI_I3C.
> >>> Like CMU_MISC, this provides clocks for MISC, GIC and OTP.
> >>> Like CMU_HSI0, this provides clocks for PCIE.
> >>> Like CMU_HSI1, this provides clocks for USB and MMC.
> >>>
> >>> Signed-off-by: Sunyeal Hong <sunyeal.hong@...sung.com>
> >>> ---
> >>
> >> ...
> >>
> >>> +
> >>>  static int __init exynosautov920_cmu_probe(struct platform_device
> >>> *pdev)  {
> >>>  	const struct samsung_cmu_info *info; @@ -1154,6 +1431,19 @@ static
> >>> const struct of_device_id exynosautov920_cmu_of_match[] = {
> >>>  	{
> >>>  		.compatible = "samsung,exynosautov920-cmu-peric0",
> >>>  		.data = &peric0_cmu_info,
> >>> +	}, {
> >>> +		 .compatible = "samsung,exynosautov920-cmu-peric1",
> >>> +		 .data = &peric1_cmu_info,
> >>> +	}, {
> >>> +		 .compatible = "samsung,exynosautov920-cmu-misc",
> >>> +		 .data = &misc_cmu_info,
> >>> +	}, {
> >>> +		.compatible = "samsung,exynosautov920-cmu-hsi0",
> >>> +		.data = &hsi0_cmu_info,
> >>> +	}, {
> >>> +		.compatible = "samsung,exynosautov920-cmu-hsi1",
> >>> +		.data = &hsi1_cmu_info,
> >>> +	}, {
> >>
> >> This is unrelated change. Please rebase.
> >>
> > Could you please explain in more detail the comment mentioned above?
> 
> You were growing this list, didn't you? Then adding sentinel is unrelated.
> 

I have confirmed that the sentinel is being applied duplicately. I will send you a patch after fixing it.

Best Regards,
sunyeal
> 
> Best regards,
> Krzysztof
>