[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<PSAPR06MB494943F3F34881D23CEEBD9A897D2@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Mon, 7 Oct 2024 09:26:13 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
<joel@....id.au>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "lee@...nel.org" <lee@...nel.org>,
"catalin.marinas@....com" <catalin.marinas@....com>, "will@...nel.org"
<will@...nel.org>, "arnd@...db.de" <arnd@...db.de>, "olof@...om.net"
<olof@...om.net>, "soc@...nel.org" <soc@...nel.org>,
"mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org"
<sboyd@...nel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>, "neil.armstrong@...aro.org"
<neil.armstrong@...aro.org>, "m.szyprowski@...sung.com"
<m.szyprowski@...sung.com>, "nfraprado@...labora.com"
<nfraprado@...labora.com>, "u-kumar1@...com" <u-kumar1@...com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org"
<linux-clk@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb
compatible string
> > Hi Krzk,
> >
> >>> ---
> >>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++
> >>> 1 file changed, 5 insertions(+)
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> >>> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> >>> index 71c31c08a8ad..b21551817f44 100644
> >>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> >>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> >>> @@ -99,4 +99,9 @@ properties:
> >>> - ufispace,ncplite-bmc
> >>> - const: aspeed,ast2600
> >>>
> >>> + - description: AST2700 based boards
> >>> + items:
> >>> + - enum:
> >>> + - aspeed,ast2700-evb
> >>
> >> NAK, this cannot be alone. Look at all other examples. Why are you
> >> doing things differently?
> > Disagree, ast2700-evb is 7th generation IC in ASPEED.
>
> I gave you argument and you just respond "disagree" with unrelated
> statement?
> > It not in the sub-set of AST2400/AST2500/AST2600 based boards.
>
>
> ? That does not answer at all my concerns. Bring me any example doing this
> that way: single board compatible.
In current stage, we only have one kind of ASPEED AST2700 evaluation board.
Should I add const for aspeed,ast2700 as the following.
- description: AST2700 based boards
items:
- enum:
- aspeed,ast2700-evb
- const: aspeed,ast2700
>
> Answer to the argument, instead of bringing useless text "ast is a board". Yeah,
> of course it is. What else could it be? A ship? A car?
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists