linux-kernel - Re: [PATCH 0/3] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1b6c598-0200-49b3-b1af-176826a5e83f@linux.ibm.com>
Date: Mon, 7 Oct 2024 06:02:03 -0500
From: Danny Tsen <dtsen@...ux.ibm.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: linux-crypto@...r.kernel.org, stable@...r.kernel.org, leitao@...ian.org,
        nayna@...ux.ibm.com, appro@...ptogams.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        mpe@...erman.id.au, ltcgcw@...ux.vnet.ibm.com, dtsen@...ibm.com
Subject: Re: [PATCH 0/3] crypto: Fix data mismatch over ipsec tunnel
 encrypted/decrypted with ppc64le AES/GCM module.

Thanks Herbert.

-Danny

On 10/5/24 12:35 AM, Herbert Xu wrote:
> On Mon, Sep 23, 2024 at 09:30:37AM -0400, Danny Tsen wrote:
>> Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.
>>
>> This patch is to fix an issue when simd is not usable that data mismatch
>> may occur. The fix is to register algs as SIMD modules so that the
>> algorithm is excecuted when SIMD instructions is usable.
>>
>> A new module rfc4106(gcm(aes)) is also added. Re-write AES/GCM assembly
>> codes with smaller footprints and small performance gain.
>>
>> This patch has been tested with the kernel crypto module tcrypt.ko and
>> has passed the selftest.  The patch is also tested with
>> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
>>
>> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
>> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
>> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
>>
>> Signed-off-by: Danny Tsen <dtsen@...ux.ibm.com>
>>
>> Danny Tsen (3):
>>    crypto: Re-write AES/GCM stitched implementation for ppcle64.
>>    crypto: Register modules as SIMD modules for ppcle64 AES/GCM algs.
>>    crypto: added CRYPTO_SIMD in Kconfig for CRYPTO_AES_GCM_P10.
>>
>>   arch/powerpc/crypto/Kconfig            |    2 +-
>>   arch/powerpc/crypto/aes-gcm-p10-glue.c |  141 +-
>>   arch/powerpc/crypto/aes-gcm-p10.S      | 2421 +++++++++++-------------
>>   3 files changed, 1187 insertions(+), 1377 deletions(-)
>>
>> -- 
>> 2.43.0
> All applied.  Thanks.