linux-kernel - Re: [PATCH] netfs: In readahead, put the folio refs as soon extracted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241007-eifrig-zinsniveau-7b31e4c4a4ab@brauner>
Date: Mon,  7 Oct 2024 13:48:46 +0200
From: Christian Brauner <brauner@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: Christian Brauner <brauner@...nel.org>,
	Matthew Wilcox <willy@...radead.org>,
	Jeff Layton <jlayton@...nel.org>,
	netfs@...ts.linux.dev,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfs: In readahead, put the folio refs as soon extracted

On Fri, 04 Oct 2024 15:33:58 +0100, David Howells wrote:
> netfslib currently defers dropping the ref on the folios it obtains during
> readahead to after it has started I/O on the basis that we can do it whilst
> we wait for the I/O to complete, but this runs the risk of the I/O
> collection racing with this in future.
> 
> Furthermore, Matthew Wilcox strongly suggests that the refs should be
> dropped immediately, as readahead_folio() does (netfslib is using
> __readahead_batch() which doesn't drop the refs).
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] netfs: In readahead, put the folio refs as soon extracted
      https://git.kernel.org/vfs/vfs/c/796a4049640b