linux-kernel - Re: [PATCH v1] dma: fix typo in the comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-8b05e8aa-ec7d-4ccf-883f-5e88cd86ad4f@palmer-ri-x1c9>
Date: Mon, 07 Oct 2024 05:25:04 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: yanzhen@...o.com
CC: vkoul@...nel.org, Paul Walmsley <paul.walmsley@...ive.com>,
  samuel.holland@...ive.com, michal.simek@....com, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
  linux-riscv@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, opensource.kernel@...o.com,
  yanzhen@...o.com
Subject:     Re: [PATCH v1] dma: fix typo in the comment

On Tue, 17 Sep 2024 20:41:14 PDT (-0700), yanzhen@...o.com wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
>
> Replace 'enngine' with 'engine' in the comment &
> replace 'trascatioin' with 'transaction' in the comment &
> replace 'descripter' with 'descriptor' in the comment &
> replace 'descritpor' with 'descriptor' in the comment &
> replace 'rgisters' with 'registers' in the comment.
>
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---
>  drivers/dma/mv_xor_v2.c         | 2 +-
>  drivers/dma/sf-pdma/sf-pdma.c   | 2 +-

Acked-by: Palmer Dabbelt <palmer@...osinc.com>

for the SiFive stuff.  I'm happy to pick this up via the RISC-V tree if 
people want, but it's mostly for other stuff so I'm going to leave it 
alone for now.

Thanks!

>  drivers/dma/sh/shdma-base.c     | 2 +-
>  drivers/dma/sh/usb-dmac.c       | 2 +-
>  drivers/dma/xilinx/zynqmp_dma.c | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index c8c67f4d982c..c6c9702dcca0 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -635,7 +635,7 @@ static int mv_xor_v2_descq_init(struct mv_xor_v2_device *xor_dev)
>  	writel(MV_XOR_V2_DESC_NUM,
>  	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_SIZE_OFF);
>
> -	/* write the DESQ address to the DMA enngine*/
> +	/* write the DESQ address to the DMA engine*/
>  	writel(lower_32_bits(xor_dev->hw_desq),
>  	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BALR_OFF);
>  	writel(upper_32_bits(xor_dev->hw_desq),
> diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
> index 428473611115..538a7bc58108 100644
> --- a/drivers/dma/sf-pdma/sf-pdma.c
> +++ b/drivers/dma/sf-pdma/sf-pdma.c
> @@ -354,7 +354,7 @@ static irqreturn_t sf_pdma_done_isr(int irq, void *dev_id)
>  	if (!residue) {
>  		tasklet_hi_schedule(&chan->done_tasklet);
>  	} else {
> -		/* submit next trascatioin if possible */
> +		/* submit next transaction if possible */
>  		struct sf_pdma_desc *desc = chan->desc;
>
>  		desc->src_addr += desc->xfer_size - residue;
> diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
> index 588c5f409a80..fdd41e1c2263 100644
> --- a/drivers/dma/sh/shdma-base.c
> +++ b/drivers/dma/sh/shdma-base.c
> @@ -961,7 +961,7 @@ void shdma_chan_probe(struct shdma_dev *sdev,
>
>  	spin_lock_init(&schan->chan_lock);
>
> -	/* Init descripter manage list */
> +	/* Init descriptor manage list */
>  	INIT_LIST_HEAD(&schan->ld_queue);
>  	INIT_LIST_HEAD(&schan->ld_free);
>
> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
> index f7cd0cad056c..cc7f7ee7f74a 100644
> --- a/drivers/dma/sh/usb-dmac.c
> +++ b/drivers/dma/sh/usb-dmac.c
> @@ -301,7 +301,7 @@ static struct usb_dmac_desc *usb_dmac_desc_get(struct usb_dmac_chan *chan,
>  	struct usb_dmac_desc *desc = NULL;
>  	unsigned long flags;
>
> -	/* Get a freed descritpor */
> +	/* Get a freed descriptor */
>  	spin_lock_irqsave(&chan->vc.lock, flags);
>  	list_for_each_entry(desc, &chan->desc_freed, node) {
>  		if (sg_len <= desc->sg_allocated_len) {
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index 9ae46f1198fe..18a407975e14 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -366,7 +366,7 @@ static void zynqmp_dma_init(struct zynqmp_dma_chan *chan)
>  	}
>  	writel(val, chan->regs + ZYNQMP_DMA_DATA_ATTR);
>
> -	/* Clearing the interrupt account rgisters */
> +	/* Clearing the interrupt account registers */
>  	val = readl(chan->regs + ZYNQMP_DMA_IRQ_SRC_ACCT);
>  	val = readl(chan->regs + ZYNQMP_DMA_IRQ_DST_ACCT);