[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <32040b21-370f-44af-b1fe-bd625bc3fd9d@linaro.org>
Date: Mon, 7 Oct 2024 15:00:56 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Benjamin Bara <bbara93@...il.com>, Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>
Cc: linux-sound@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org, Benjamin Bara <benjamin.bara@...data.com>,
stable@...r.kernel.org
Subject: Re: [PATCH] Revert "ASoC: tegra: machine: Handle component name
prefix"
On 07/10/2024 10:12, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@...data.com>
>
> This reverts commit f82eb06a40c86c9a82537e956de401d497203d3a.
>
> Tegra is adding the DAPM of the respective widgets directly to the card
> and therefore the DAPM has no component. Without the component, the
> precondition for snd_soc_dapm_to_component() fails, which results in
> undefined behavior. Use the old implementation, as we cannot have a
> prefix without component.
>
> Cc: stable@...r.kernel.org # v6.7+
Fixes: f82eb06a40c8 ("ASoC: tegra: machine: Handle component name prefix")
I think Samsung speyside from the same patchset might repeat this mistake.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists