[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241007132700.982800-1-ymaman@nvidia.com>
Date: Mon, 7 Oct 2024 16:26:58 +0300
From: Yonatan Maman <ymaman@...dia.com>
To: <kherbst@...hat.com>, <lyude@...hat.com>, <dakr@...hat.com>,
<airlied@...il.com>, <daniel@...ll.ch>, <bskeggs@...dia.com>,
<jglisse@...hat.com>, <dri-devel@...ts.freedesktop.org>,
<nouveau@...ts.freedesktop.org>
CC: Yonatan Maman <Ymaman@...dia.com>, <linux-kernel@...r.kernel.org>,
<stable@...r.kernel.org>
Subject:
From: Yonatan Maman <Ymaman@...dia.com>
Date: Mon, 7 Oct 2024 14:48:26 +0300
Subject: [PATCH v2 0/2] drm/nouveau/dmem: Fix Memory Leaking and Device Channels configuration
This patch series addresses two critical issues in the Nouveau driver
related to device channels, error handling, and memory leaks.
- Memory Leak in migrate_to_ram: The migrate_to_ram function was
identified as leaking memory when a copy push command fails. This
results in the function returning a dirty HIGH_USER page, which can
expose sensitive information and pose a security risk. To mitigate
this vulnerability, the patch ensures that a zero page is allocated for
the destination page, thereby preventing memory leaks and enhancing
driver security in case of failure.
- Privileged Error in Copy Engine Channel: An error was observed when
the nouveau_dmem_copy_one function is executed, leading to a Host Copy
Engine Privileged error on channel 1. The patch resolves this by
adjusting the Copy Engine channel configuration to permit privileged
push commands, resolving the error.
Changes since V1:
- Fixed version according to Danilo Krummrich's comments.
Yonatan Maman (2):
nouveau/dmem: Fix privileged error in copy engine channel
nouveau/dmem: Fix memory leak in `migrate_to_ram` upon copy error
drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.34.1
Powered by blists - more mailing lists