linux-kernel - Re: [PATCH] KVM: selftests: memslot_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9071cc6f-05af-4f00-9a95-3b413b92de84@oracle.com>
Date: Mon, 7 Oct 2024 14:02:10 +0000
From: Liam Merwick <liam.merwick@...cle.com>
To: Maxim Levitsky <mlevitsk@...hat.com>,
        "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>
CC: Paolo Bonzini <pbonzini@...hat.com>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        Shuah Khan <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Liam Merwick
	<liam.merwick@...cle.com>
Subject: Re: [PATCH] KVM: selftests: memslot_perf_test: increase guest sync
 timeout

On 04/10/2024 23:01, Maxim Levitsky wrote:
> When memslot_perf_test is run nested, first iteration of test_memslot_rw_loop
> testcase, sometimes takes more than 2 seconds due to build of shadow page tables.
> 
> Following iterations are fast.
> 
> To be on the safe side, bump the timeout to 10 seconds.
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>

I see the issue without this fix.

Tested-by: Liam Merwick <liam.merwick@...cle.com>
Reviewed-by: Liam Merwick <liam.merwick@...cle.com>


> ---
>   tools/testing/selftests/kvm/memslot_perf_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c
> index 893366982f77b..e9189cbed4bb6 100644
> --- a/tools/testing/selftests/kvm/memslot_perf_test.c
> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c
> @@ -415,7 +415,7 @@ static bool _guest_should_exit(void)
>    */
>   static noinline void host_perform_sync(struct sync_area *sync)
>   {
> -	alarm(2);
> +	alarm(10);
>   
>   	atomic_store_explicit(&sync->sync_flag, true, memory_order_release);
>   	while (atomic_load_explicit(&sync->sync_flag, memory_order_acquire))