linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: add TUSB73x0 PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172831060758.15259.15265542019562102842.robh@kernel.org>
Date: Mon, 07 Oct 2024 09:16:48 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: linux-kernel@...r.kernel.org, 
 Parth Pancholi <parth.pancholi@...adex.com>, 
 Mathias Nyman <mathias.nyman@...el.com>, 
 Francesco Dolcini <francesco.dolcini@...adex.com>, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 linux-usb@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: add TUSB73x0 PCIe


On Mon, 07 Oct 2024 11:32:04 +0200, Francesco Dolcini wrote:
> From: Parth Pancholi <parth.pancholi@...adex.com>
> 
> Add device tree bindings for TI's TUSB73x0 PCIe-to-USB 3.0 xHCI
> host controller. The controller supports software configuration
> through PCIe registers, such as controlling the PWRONx polarity
> via the USB control register (E0h).
> 
> Similar generic PCIe-based bindings can be found as qcom,ath11k-pci.yaml
> as an example.
> 
> Datasheet: https://www.ti.com/lit/ds/symlink/tusb7320.pdf
> Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
> v2: rename property to ti,tusb7320-pwron-active-high and change type to flag
> ---
>  .../bindings/usb/ti,tusb73x0-pci.yaml         | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/ti,tusb73x0-pci.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,tusb73x0-pci.example.dtb: pcie@0: usb@0:compatible: ['pci104C,8241'] does not contain items matching the given schema
	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007093205.27130-2-francesco@dolcini.it

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.