linux-kernel - Re: [PATCH v6 3/5] drm: handle HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3wh4nsirm5kjapft47oe3gaqgzdjwlhzku5lrctb4hhfjxicv3@n2sow3o36chc>
Date: Mon, 7 Oct 2024 09:39:33 -0500
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Niklas Schnelle <schnelle@...ux.ibm.com>
CC: Brian Cain <bcain@...cinc.com>, Marcel Holtmann <marcel@...tmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>, Patrik Jakobsson
	<patrik.r.jakobsson@...il.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, Dave Airlie <airlied@...hat.com>, "Gerd
 Hoffmann" <kraxel@...hat.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
	<jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>, "Maciej W. Rozycki"
	<macro@...am.me.uk>, Heiko Carstens <hca@...ux.ibm.com>,
	<linux-kernel@...r.kernel.org>, <linux-hexagon@...r.kernel.org>,
	<linux-bluetooth@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<virtualization@...ts.linux.dev>, <spice-devel@...ts.freedesktop.org>,
	<intel-xe@...ts.freedesktop.org>, <linux-serial@...r.kernel.org>,
	<linux-arch@...r.kernel.org>, Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v6 3/5] drm: handle HAS_IOPORT dependencies

On Mon, Oct 07, 2024 at 01:40:21PM +0200, Niklas Schnelle wrote:
>In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
>compile time. We thus need to add HAS_IOPORT as dependency for those
>drivers using them. In the bochs driver there is optional MMIO support
>detected at runtime, warn if this isn't taken when HAS_IOPORT is not
>defined.
>
>There is also a direct and hard coded use in cirrus.c which according to
>the comment is only necessary during resume.  Let's just skip this as
>for example s390 which doesn't have I/O port support also doesen't
>support suspend/resume.
>
>Co-developed-by: Arnd Bergmann <arnd@...nel.org>
>Signed-off-by: Arnd Bergmann <arnd@...nel.org>
>Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
>---
> drivers/gpu/drm/gma500/Kconfig |  2 +-
> drivers/gpu/drm/qxl/Kconfig    |  1 +
> drivers/gpu/drm/tiny/bochs.c   | 17 +++++++++++++++++
> drivers/gpu/drm/tiny/cirrus.c  |  2 ++
> drivers/gpu/drm/xe/Kconfig     |  2 +-

as an example:
$ git grep -lw outb -- drivers/gpu/drm/
drivers/gpu/drm/gma500/cdv_device.c
drivers/gpu/drm/i915/display/intel_vga.c
drivers/gpu/drm/qxl/qxl_cmd.c
drivers/gpu/drm/qxl/qxl_irq.c
drivers/gpu/drm/tiny/bochs.c
drivers/gpu/drm/tiny/cirrus.c

you are adding the dependency on xe, but why are you keeping i915 out?
What approach did you use to determine the dependency?

Lucas De Marchi