linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c98ece5f-c105-41ca-af1a-bddc61893071@kernel.org>
Date: Mon, 7 Oct 2024 16:56:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joy Chakraborty <joychakr@...gle.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thinh Nguyen
 <Thinh.Nguyen@...opsys.com>, Felipe Balbi <balbi@...nel.org>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2
 de-emphasis

On 07/10/2024 15:55, Joy Chakraborty wrote:
> PIPE4 spec defines an 18bit de-emphasis setting to be passed from
> controller to the PHY.
> TxDeemph[17:0] is split as [5:0] C-1, [11:6] C0, [17:12] C+1 for 3 tap
> filter used for USB Gen2(10GT/s).
> 
> Signed-off-by: Joy Chakraborty <joychakr@...gle.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 1cd0ca90127d..a1f1bbcf1467 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -190,6 +190,18 @@ properties:
>        - 1 # -3.5dB de-emphasis
>        - 2 # No de-emphasis
>  
> +  snps,tx_gen2_de_emphasis_quirk:

No underscores.

> +    description: When set core will set Tx de-emphasis for USB Gen2

And why it cannot be implied by compatible?

> +    type: boolean
> +
Best regards,
Krzysztof