linux-kernel - Re: [PATCH v4 0/2] virtiofs: fix the warning for kernel direct IO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegshz4_Cjj5imF9mpY=8JSGU1riBZJr0N0Jbb3ZaP9aubA@mail.gmail.com>
Date: Tue, 8 Oct 2024 15:39:09 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Hou Tao <houtao@...weicloud.com>
Cc: linux-fsdevel@...r.kernel.org, Vivek Goyal <vgoyal@...hat.com>, 
	Stefan Hajnoczi <stefanha@...hat.com>, Bernd Schubert <bernd.schubert@...tmail.fm>, 
	"Michael S . Tsirkin" <mst@...hat.com>, Matthew Wilcox <willy@...radead.org>, 
	Benjamin Coddington <bcodding@...hat.com>, Jingbo Xu <jefflexu@...ux.alibaba.com>, 
	linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev, 
	houtao1@...wei.com
Subject: Re: [PATCH v4 0/2] virtiofs: fix the warning for kernel direct IO

On Sat, 31 Aug 2024 at 11:38, Hou Tao <houtao@...weicloud.com> wrote:
>
> From: Hou Tao <houtao1@...wei.com>
>
> Hi,
>
> The patch set aims to fix the warning related to an abnormal size
> parameter of kmalloc() in virtiofs. Patch #1 fixes it by introducing
> use_pages_for_kvec_io option in fuse_conn and enabling it in virtiofs.
> Beside the abnormal size parameter for kmalloc, the gfp parameter is
> also questionable: GFP_ATOMIC is used even when the allocation occurs
> in a kworker context. Patch #2 fixes it by using GFP_NOFS when the
> allocation is initiated by the kworker. For more details, please check
> the individual patches.

Applied, thanks.

Miklos