linux-kernel - Re: [PATCH -v2] Resource: fix region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871q0rnw6n.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Tue, 08 Oct 2024 10:52:00 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Dan Williams <dan.j.williams@...el.com>,  Andrew Morton
 <akpm@...ux-foundation.org>,  <linux-mm@...ck.org>,
  <linux-kernel@...r.kernel.org>,  <linux-cxl@...r.kernel.org>,  "David
 Hildenbrand" <david@...hat.com>,  Davidlohr Bueso <dave@...olabs.net>,
  "Jonathan Cameron" <jonathan.cameron@...wei.com>,  Dave Jiang
 <dave.jiang@...el.com>,  Alison Schofield <alison.schofield@...el.com>,
  Vishal Verma <vishal.l.verma@...el.com>,  Ira Weiny
 <ira.weiny@...el.com>,  Alistair Popple <apopple@...dia.com>,  Bjorn
 Helgaas <bhelgaas@...gle.com>,  Baoquan He <bhe@...hat.com>,  Philip Li
 <philip.li@...el.com>
Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

> On Fri, Sep 06, 2024 at 09:07:41AM +0800, Huang, Ying wrote:
>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>> > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote:
>> >> Huang, Ying wrote:
>> >> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>
> [..]
>
>> >> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit
>> >> > > message.
>> >> > 
>> >> > Emm... It appears that it's a common practice to include "Cc" in the
>> >> > commit log.
>> >> 
>> >> Yes, just ignore this feedback, it goes against common practice. Cc list
>> >> as is looks sane to me.
>> >
>> > It seems nobody can give technical arguments why it's better than just keeping
>> > them outside of the commit message. Mantra "common practice" nowadays is
>> > questionable.
>> 
>> Cc list is used by 0day test robot to notify relevant developers and
>> maintainers in addition to the author when reporting regressions.  That
>> is helpful information.
>
> I'm not objecting Cc email tags, I'm objecting having them in the commit messages!
> Can you explain, how useful they are when they are placed as part of commit message
> bodies?

The result of regression bisection is the first bad commit.  Where we
use the Cc list in commit message to help find out whom we should send
the report email to.

--
Best Regards,
Huang, Ying