linux-kernel - Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db160fbd-ba7a-4cd0-88ed-2970a90c209b@arm.com>
Date: Tue, 8 Oct 2024 15:20:33 +0100
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Arnd Bergmann <arnd@...db.de>, Thomas Gleixner <tglx@...utronix.de>,
 linux-kernel@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>,
 linux-mm@...ck.org
Cc: Andy Lutomirski <luto@...nel.org>, "Jason A . Donenfeld"
 <Jason@...c4.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

On 08/10/2024 14:11, Arnd Bergmann wrote:
> On Mon, Oct 7, 2024, at 16:23, Thomas Gleixner wrote:
>> On Fri, Oct 04 2024 at 13:13, Arnd Bergmann wrote:
>>> On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote:
>>>> The VDSO implementation includes headers from outside of the
>>>> vdso/ namespace.
>>>>
>>>> Introduce vdso/page.h to make sure that the generic library
>>>> uses only the allowed namespace.
>>>>
>>>> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when
>>>> it supports 64-bit phys_addr_t we might end up in situation in which the
>>>> top 32 bit are cleared. To prevent this issue this patch provides
>>>> separate macros for PAGE_MASK.
>>>>
>>>> Cc: Arnd Bergmann <arnd@...db.de>
>>>> Cc: Andy Lutomirski <luto@...nel.org>
>>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>>> Cc: Jason A. Donenfeld <Jason@...c4.com>
>>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
>>>
>>> Looks good to me. I would apply this to the asm-generic
>>> tree for 6.13, but there is one small detail I'm unsure
>>> about:
>>
>> Please don't. We have related changes upcoming for VDSO which would
>> heavily conflict. I rather take it through my tree.
> 
> Ok.
> 
> Vincenzo, in that case please add 
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> 
> to the two paches when you send v4 to Thomas.
>

Thank you Arnd and Thomas,

I am completing the testing and will do that.

>      Arnd

-- 
Regards,
Vincenzo