linux-kernel - Re: [PATCH 2/2] mmc: davinci: use generic device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqThmrHB76ermV9vRX8PsgWxKiKo7XUpLQzeBcoqvMHqA@mail.gmail.com>
Date: Tue, 8 Oct 2024 16:36:26 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] mmc: davinci: use generic device_get_match_data()

On Mon, 7 Oct 2024 at 13:49, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> There's no reason for this driver to use the OF-specific variant so
> switch to using the generic device_get_match_data() helper instead.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/davinci_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index fe7712532e84..cde4c4339ab7 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -21,9 +21,9 @@
>  #include <linux/mmc/mmc.h>
>  #include <linux/mmc/slot-gpio.h>
>  #include <linux/module.h>
> -#include <linux/of.h>
>  #include <linux/platform_data/mmc-davinci.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>
>  /*
>   * Register Definitions
> @@ -1228,7 +1228,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
>
>         host->mmc_input_clk = clk_get_rate(host->clk);
>
> -       pdev->id_entry = of_device_get_match_data(&pdev->dev);
> +       pdev->id_entry = device_get_match_data(&pdev->dev);
>         if (pdev->id_entry) {
>                 ret = mmc_of_parse(mmc);
>                 if (ret) {
> --
> 2.43.0
>