linux-kernel - Re: [PATCH v1 2/2] selftests/rseq: Fix mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c3a8650-c855-41d2-b500-6a72e45c057c@efficios.com>
Date: Tue, 8 Oct 2024 10:56:23 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Shuah Khan <skhan@...uxfoundation.org>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>
Cc: linux-kernel@...r.kernel.org, "Paul E. McKenney" <paulmck@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>, Valentin Schneider <vschneid@...hat.com>,
 Mel Gorman <mgorman@...e.de>, Steven Rostedt <rostedt@...dmis.org>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Ben Segall
 <bsegall@...gle.com>, Yury Norov <yury.norov@...il.com>,
 Rasmus Villemoes <linux@...musvillemoes.dk>,
 "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
 Carlos O'Donell <carlos@...hat.com>, Florian Weimer <fweimer@...hat.com>
Subject: Re: [PATCH v1 2/2] selftests/rseq: Fix mm_cid test failure

On 2024-10-04 21:18, Shuah Khan wrote:
> On 10/3/24 18:44, Mathieu Desnoyers wrote:
>> Adapt the rseq.c/rseq.h code to follow GNU C library changes 
>> introduced by:
>>
>> commit 2e456ccf0c34 ("Linux: Make __rseq_size useful for feature 
>> detection (bug 31965)")
>>
>> Without this fix, rseq selftests for mm_cid fail:
>>
>> ./run_param_test.sh
>> Default parameters
>> Running test spinlock
>> Running compare-twice test spinlock
>> Running mm_cid test spinlock
>> Error: cpu id getter unavailable
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> CC: Boqun Feng <boqun.feng@...il.com>
>> CC: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
>> Cc: Shuah Khan <skhan@...uxfoundation.org>
>> CC: Carlos O'Donell <carlos@...hat.com>
>> CC: Florian Weimer <fweimer@...hat.com>
>> ---
>>   tools/testing/selftests/rseq/rseq.c | 109 +++++++++++++++++++---------
>>   tools/testing/selftests/rseq/rseq.h |  10 +--
>>   2 files changed, 76 insertions(+), 43 deletions(-)
>>
> 
> Looks good to me.
> 
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>
> 
> Peter, Ingo - let me know if you plan to take this through
> one of your trees. Otherwise I will pick it up.

Hi Shuah,

I just discussed with Peter on IRC, and if you can pick up
this rseq selftest fix through your tree it would be very much
appreciated,

Thanks,

Mathieu

> 
> thanks,
> -- Shuah
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com