linux-kernel - Re: [PATCH v2 6/7] iio: adc: ad485x: add ad485x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdPcLE6Dgi=itocv+JSjh+3ZiF2xQ6wOp8ZiT+miekmcg@mail.gmail.com>
Date: Tue, 8 Oct 2024 18:57:47 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	"Hennerich, Michael" <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"Sa, Nuno" <Nuno.Sa@...log.com>, Olivier Moysan <olivier.moysan@...s.st.com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, David Lechner <dlechner@...libre.com>, 
	"Schmitt, Marcelo" <Marcelo.Schmitt@...log.com>, Mike Looijmans <mike.looijmans@...ic.nl>, 
	Marius Cristea <marius.cristea@...rochip.com>, Dumitru Ceclan <mitrutzceclan@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Alisa-Dariana Roman <alisadariana@...il.com>, Ivan Mikhaylov <fr0st61te@...il.com>, 
	"Cuciurean, Sergiu" <Sergiu.Cuciurean@...log.com>, "Bogdan, Dragos" <Dragos.Bogdan@...log.com>, 
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>
Subject: Re: [PATCH v2 6/7] iio: adc: ad485x: add ad485x driver

On Tue, Oct 8, 2024 at 1:48 PM Miclaus, Antoniu
<Antoniu.Miclaus@...log.com> wrote:

...

> > > +       int gain;
> >
> > Should be u8 gain[2] and...

I should have added "...independently of the use of bulk operations."

> As discussed in previous patch series, the bulk operations won't work for these
> chips. The CS needs to be raised between each byte read/written.

And as it was put independently by two people, we should really know
the real issue on the wire with this. And if it's as described, try to
find an existing example in the kernel that uses a similar approach. I
think regmap SPI should have such a feature.

> Therefore using u8 gain[2]  here  and in other places will be just an extra populated
> array since  regmap_read requires `unsigned int` as input.

The problem here is open coded endianess conversion.

-- 
With Best Regards,
Andy Shevchenko