linux-kernel - Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241008163312.GS275077@black.fi.intel.com>
Date: Tue, 8 Oct 2024 19:33:12 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Oleksandr Ocheretnyi <oocheret@...co.com>
Cc: linux@...ck-us.net, jdelvare@...e.de, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org, wim@...ux-watchdog.org,
	wsa@...nel.org, xe-linux-external@...co.com
Subject: Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit()
 call

On Mon, Oct 07, 2024 at 08:57:02AM -0700, Oleksandr Ocheretnyi wrote:
> Hello Mika,
> 
> > I suggest adding some #define for the magical number 8 so that it is
> > easier for anyone looking at this driver to figure out what it is doing.
> 
> Are the changes with #define NMI_NOW bit fine for you?

Sure,

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>