linux-kernel - [PATCH] Sound:mixer_scarlett2:Add error check after retrieving PEQ filter values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241008031947.10906-1-zhujun2@cmss.chinamobile.com>
Date: Mon,  7 Oct 2024 20:19:47 -0700
From: Zhu Jun <zhujun2@...s.chinamobile.com>
To: perex@...ex.cz
Cc: g@...vu,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	zhujun2@...s.chinamobile.com
Subject: [PATCH] Sound:mixer_scarlett2:Add error check after retrieving PEQ filter values

Add error check after retrieving PEQ filter values in scarlett2_update_filter_values
that ensure function returns error if PEQ filter value retrieval fails

Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
---
 sound/usb/mixer_scarlett2.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
index 1150cf104985..1b864a9621ba 100644
--- a/sound/usb/mixer_scarlett2.c
+++ b/sound/usb/mixer_scarlett2.c
@@ -5614,6 +5614,9 @@ static int scarlett2_update_filter_values(struct usb_mixer_interface *mixer)
 			SCARLETT2_BIQUAD_COEFFS,
 		peq_flt_values);
 
+	if (err < 0)
+		return err;
+
 	for (i = 0, dst_idx = 0; i < info->dsp_input_count; i++) {
 		src_idx = i *
 			  info->peq_flt_total_count *
-- 
2.17.1