linux-kernel - re: ASoC: rt721-sdca: Add RT721 SDCA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d4ff08fa-199d-4114-bae1-fd36f6a9313c@gmail.com>
Date: Tue, 8 Oct 2024 18:02:37 +0100
From: "Colin King (gmail)" <colin.i.king@...il.com>
To: Jack Yu <jack.yu@...ltek.com>, linux-sound@...r.kernel.org
Cc: Mark Brown <broonie@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: ASoC: rt721-sdca: Add RT721 SDCA driver

Hi Jack,

With respect to the recent commit in linux-next:

commit 86ce355c1f9ab943bbe099ea7d0b8a3af2247f65
Author: Jack Yu <jack.yu@...ltek.com>
Date:   Tue Oct 1 09:17:38 2024 +0000

     ASoC: rt721-sdca: Add RT721 SDCA driver


I'm flagging up an issue in function rt721_sdca_dmic_set_gain_get there 
are a bunch of nested if statements as follows:

                 if (!adc_vol_flag) /* boost gain */
                         ctl = regvalue / boost_step;
                 else { /* ADC gain */
                         if (adc_vol_flag)
                                 ctl = p->max - (((vol_max - regvalue) & 
0xffff) / interval_offset);
                         else
                                 ctl = p->max - (((0 - regvalue) & 
0xffff) / interval_offset);
                 }

The last else statement ctl = p->max - (((0 - regvalue) & 0xffff) / 
interval_offset) is redundant, since this is the !adc_vol_flag checked 
for in the first boost gain if clause.

Colin