[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <67056638.050a0220.179d84.0dc1@mx.google.com>
Date: Tue, 8 Oct 2024 19:04:54 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v2] net: phy: Validate PHY LED OPs presence
before registering
On Tue, Oct 08, 2024 at 07:02:18PM +0200, Andrew Lunn wrote:
> On Tue, Oct 08, 2024 at 03:13:34PM +0200, Christian Marangi wrote:
> > On Tue, Oct 08, 2024 at 03:08:32PM +0200, Andrew Lunn wrote:
> > > > + /* Check if the PHY driver have at least an OP to
> > > > + * set the LEDs.
> > > > + */
> > > > + if (!phydev->drv->led_brightness_set &&
> > > > + !phydev->drv->led_blink_set &&
> > > > + !phydev->drv->led_hw_control_set) {
> > >
> > > I think this condition is too strong. All that should be required is
> > > led_brightness_set(). The rest can be done in software.
> > >
> >
> > Mhh the idea was really to check if one of the 3 is declared. Ideally to
> > future proof case where some led will only expose led_hw_control_set or
> > only led_blink_set?
>
> Ah, i read it wrong. Sorry.
>
> Maybe apply De Morgan's laws to make it more readable?
>
> + if (!(phydev->drv->led_brightness_set ||
> + phydev->drv->led_blink_set ||
> + phydev->drv->led_hw_control_set)) {
>
> However, it is correct as is.
>
Happy to send v3. Np!
--
Ansuel
Powered by blists - more mailing lists