linux-kernel - Re: [PATCH v1 1/1] ufs: core: set SDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <210ebb75-d384-4787-9e1a-d08643cc4843@acm.org>
Date: Tue, 8 Oct 2024 10:58:00 -0700
From: Bart Van Assche <bvanassche@....org>
To: Seunghwan Baek <sh8267.baek@...sung.com>, linux-kernel@...r.kernel.org,
 linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
 James.Bottomley@...senPartnership.com, avri.altman@....com,
 alim.akhtar@...sung.com
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, junwoo80.lee@...sung.com,
 dh0421.hwang@...sung.com, jangsub.yi@...sung.com, sh043.lee@...sung.com,
 cw9316.lee@...sung.com, wkon.kim@...sung.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] ufs: core: set SDEV_OFFLINE when ufs shutdown.

On 8/29/24 2:39 AM, Seunghwan Baek wrote:
> There is a history of dead lock as reboot is performed at the beginning of
> booting. SDEV_QUIESCE was set for all lu's scsi_devices by ufs shutdown,
> and at that time the audio driver was waiting on blk_mq_submit_bio holding
> a mutex_lock while reading the fw binary. After that, a deadlock issue
> occurred while audio driver shutdown was waiting for mutex_unlock of
> blk_mq_submit_bio. To solve this, set SDEV_OFFLINE for all lus except wlun,
> so that any i/o that comes down after a ufs shutdown will return an error.

Reviewed-by: Bart Van Assche <bvanassche@....org>