linux-kernel - Re: [PATCH] driver core: Fix a typo in __dev_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76254295771cb4ea5644f2ce4a30f0d7@manjaro.org>
Date: Tue, 08 Oct 2024 21:02:38 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: linux-spi@...r.kernel.org, linux-rockchip@...ts.infradead.org
Cc: broonie@...nel.org, heiko@...ech.de, gregkh@...uxfoundation.org,
 rafael@...nel.org, oss@...ene.moe, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: Fix a typo in __dev_probe_failed() comments

On 2024-10-08 19:29, Dragan Simic wrote:
> Fix a small typo in one of the variable names found in the comment 
> block
> inside the __dev_probe_failed() function.
> 
> Signed-off-by: Dragan Simic <dsimic@...jaro.org>
> ---
> 
> Notes:
>     This is an incremental patch for the patch series [1] that's been 
> already
>     merged, so it should be applied on top of the series.
> 
>     [1] 
> https://lore.kernel.org/linux-rockchip/cover.1727601608.git.dsimic@manjaro.org/T/#u

Please disregard this patch, Mark will have both spotted typos [2]
fixed by hand. [3]  Sorry for the noise.

[2] 
https://lore.kernel.org/linux-spi/e8cbbf877cc0e6838afd2d6de3b7bfa1@manjaro.org/
[3] 
https://lore.kernel.org/linux-spi/ZwVt9e44jc3CQaV1@finisterre.sirena.org.uk/

>  drivers/base/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 5f156a9a10a4..a84a7b952cfd 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -4989,7 +4989,7 @@ static void __dev_probe_failed(const struct
> device *dev, int err, bool fatal,
>  	/*
>  	 * On x86_64 and possibly on other architectures, va_list is actually 
> a
>  	 * size-1 array containing a structure.  As a result, function 
> parameter
> -	 * vargps decays from T[1] to T*, and &vargsp has type T** rather 
> than
> +	 * vargsp decays from T[1] to T*, and &vargsp has type T** rather 
> than
>  	 * T(*)[1], which is expected by its assignment to vaf.va below.
>  	 *
>  	 * One standard way to solve this mess is by creating a copy in a 
> local