linux-kernel - Re: [PATCH v3] selftests: sched_ext: Add sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efee099b-f478-4bfb-8c6c-90934934477e@linuxfoundation.org>
Date: Tue, 8 Oct 2024 14:09:01 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Björn Töpel <bjorn@...nel.org>,
 Tejun Heo <tj@...nel.org>, David Vernet <void@...ifault.com>,
 Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Mark Brown <broonie@...nel.org>
Cc: Björn Töpel <bjorn@...osinc.com>,
 bpf@...r.kernel.org, linux-riscv@...ts.infradead.org,
 Anders Roxell <anders.roxell@...aro.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] selftests: sched_ext: Add sched_ext as proper selftest
 target

On 10/8/24 09:35, Björn Töpel wrote:
> From: Björn Töpel <bjorn@...osinc.com>
> 
> The sched_ext selftests is missing proper cross-compilation support, a
> proper target entry, and out-of-tree build support.
> 
> When building the kselftest suite, e.g.:
> 
>    make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu-  \
>      TARGETS=sched_ext SKIP_TARGETS="" O=/output/foo \
>      -C tools/testing/selftests install
> 
> or:
> 
>    make ARCH=arm64 LLVM=1 TARGETS=sched_ext SKIP_TARGETS="" \
>      O=/output/foo -C tools/testing/selftests install
> 
> The expectation is that the sched_ext is included, cross-built, the
> correct toolchain is picked up, and placed into /output/foo.
> 
> In contrast to the BPF selftests, the sched_ext suite does not use
> bpftool at test run-time, so it is sufficient to build bpftool for the
> build host only.
> 
> Add ARCH, CROSS_COMPILE, OUTPUT, and TARGETS support to the sched_ext
> selftest. Also, remove some variables that were unused by the
> Makefile.

Thank you for adding this to change log.
Maybe we need to add this to kselftest.rst at some point.

> 
> Signed-off-by: Björn Töpel <bjorn@...osinc.com>
> ---
> v3: * Always build a build host version of bpftool (Mark)
>      * Make sure LLVM style "ARCH only" cross-build works (Mark)
>      
> v2: * Removed the duplicated LLVM prefix parsing (David)
>      * Made sure make clean didn't do a complete mess (David)
>      * Added sched_ext to default skip (Shuah)

Thank you.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah