linux-kernel - Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add FID map cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fd54d40-ccba-428c-b194-1e9cf697ed83@lunn.ch>
Date: Tue, 8 Oct 2024 23:25:05 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Aryan Srivastava <aryan.srivastava@...iedtelesis.co.nz>
Cc: Marek Behún <kabel@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add FID map cache

On Mon, Oct 07, 2024 at 10:29:05AM +1300, Aryan Srivastava wrote:
> Add a cached FID bitmap. This mitigates the need to walk all VTU entries
> to find the next free FID.
> 
> When flushing the VTU (during init), zero the FID bitmap. Use and
> manipulate this bitmap from now on, instead of reading HW for the FID
> map.
> 
> The repeated VTU walks are costly and can take ~40 mins if ~4000 vlans
> are added. Caching the FID map reduces this time to <2 mins.
> 
> Signed-off-by: Aryan Srivastava <aryan.srivastava@...iedtelesis.co.nz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew