[<prev] [next>] [day] [month] [year] [list]
Message-ID:
<SHXPR01MB0863DEE88A17DF86B4657F4EE67E2@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 8 Oct 2024 10:22:53 +0000
From: Minda Chen <minda.chen@...rfivetech.com>
To: Serge Semin <fancer.lancer@...il.com>, Jakub Kicinski <kuba@...nel.org>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
<joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Maxime
Coquelin <mcoquelin.stm32@...il.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH net-next v2] net: stmmac: dwmac4: Add ip payload error
statistics
>
> Hi Jakub
>
> On Wed, Oct 02, 2024 at 06:58:01AM GMT, Jakub Kicinski wrote:
> > On Mon, 30 Sep 2024 19:02:05 +0800 Minda Chen wrote:
> > > Add dwmac4 ip payload error statistics, and rename discripter bit
> > > macro
> >
> > descriptor
> > ^
> >
> > > because latest version descriptor IPCE bit claims ip checksum error
> > > or
> > > l4 segment length error.
> >
>
I will modify this.
> > What is an L4 segment length error on Rx?
> > Seems to me that reusing ip_payload_err here will be confusing
>
> From the current "ip_payload_err" field semantics, Minda is correct to use it for
> the Rx IP-payload error statistics. Here is the definition of the IPCE flag (part of
> the RDES4 descriptor field) cited from the Synopsys DW QoS Eth v5 HW-manual:
>
> Bit Name Description
> 7 IPCE IP Payload Error
> When this bit is set, it indicates either of the following:
> ■ The 16-bit IP payload checksum (that is, the TCP, UDP, or ICMP
> checksum) calculated by the
> MAC does not match the corresponding checksum field in the
> received segment.
> ■ The TCP, UDP, or ICMP segment length does not match the
> payload length value in the IP Header
> field.
> ■ The TCP, UDP, or ICMP segment length is less than minimum
> allowed segment length for TCP,
> UDP, or ICMP.
>
Thanks for adding description.. I will add the this to commit message.
Powered by blists - more mailing lists