linux-kernel - Re: [PATCH v2] selftests: vDSO: Explicitly include sched.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4564d4e0-6384-4b84-a330-fdd6a026c9d6@linuxfoundation.org>
Date: Tue, 8 Oct 2024 15:50:33 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Yu Liao <liaoyu15@...wei.com>, shuah@...nel.org
Cc: xiexiuqi@...wei.com, Jason@...c4.com, christophe.leroy@...roup.eu,
 broonie@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: vDSO: Explicitly include sched.h

On 10/7/24 20:33, Yu Liao wrote:
> The previous commit introduced the use of CLONE_NEWTIME without including
> <sched.h> which contains its definition.
> 
> Add an explicit include of <sched.h> to ensure that CLONE_NEWTIME
> is correctly defined before it is used.
> 
> Fixes: 2aec90036dcd ("selftests: vDSO: ensure vgetrandom works in a time namespace")
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
> ---
> Changes in v2:
> - Include <sched.h> instead of <linux/sched.h>
> 
> v1: https://lore.kernel.org/all/20240919111841.20226-1-liaoyu15@huawei.com/
> 
>   tools/testing/selftests/vDSO/vdso_test_getrandom.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index 72a1d9b43a84..ddf37e3ab18b 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -11,6 +11,7 @@
>   #include <string.h>
>   #include <time.h>
>   #include <unistd.h>
> +#include <sched.h>
>   #include <signal.h>
>   #include <sys/auxv.h>
>   #include <sys/mman.h>

Thank you. Applied to linux-kselftest fixes for next rc.

thanks,
-- Shuah