linux-kernel - Re: [PATCH v4 RESEND] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2410090014370.20286@cbobk.fhfr.pm>
Date: Wed, 9 Oct 2024 00:15:50 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Stuart <stuart.a.hayhurst@...il.com>
cc: linux-input@...r.kernel.org, Benjamin Tissoires <bentiss@...nel.org>, 
    Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 RESEND] HID: corsair-void: Add Corsair Void headset
 family driver

On Tue, 8 Oct 2024, Stuart wrote:

> > As we alreay have general CONFIG_HID_CORSAIR, I think it'd make sense for
> > this driver to be encapsulated under this config option as well (it'd also
> > follow the general practice of HID subsystem, that the drivers are divided
> > per vendor) -- i.e. link hid-corsair-void into the final hid-corsair.ko
> > whenever CONFIG_HID_CORSAIR is selected.
> >
> > Would you be willing to make that small change, and resubmit for final
> > merge?
> 
> Sure that makes sense, but I'm not sure how to do that exactly. Is
> there an example anywhere?

Just do something like

	obj-$(CONFIG_HID_CORSAIR)  += hid-corsair.o hid-corsair-void.o

in the Makefile. There are a few HID drivers there doing exactly that. 
hid-roccat is probably the biggest user of this :)

Thanks,

-- 
Jiri Kosina
SUSE Labs