linux-kernel - Re: [PATCH v5 40/40] x86/resctrl: Add python script to move resctrl code to /fs/resctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwW7cWgXJmfW8AQP@agluck-desk3.sc.intel.com>
Date: Tue, 8 Oct 2024 16:08:33 -0700
From: Tony Luck <tony.luck@...el.com>
To: James Morse <james.morse@....com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Fenghua Yu <fenghua.yu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	shameerali.kolothum.thodi@...wei.com,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	carl@...amperecomputing.com, lcherian@...vell.com,
	bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
	baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
	dfustini@...libre.com, amitsinght@...vell.com,
	David Hildenbrand <david@...hat.com>,
	Rex Nie <rex.nie@...uarmicro.com>,
	Dave Martin <dave.martin@....com>,
	Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH v5 40/40] x86/resctrl: Add python script to move resctrl
 code to /fs/resctrl

On Fri, Oct 04, 2024 at 06:03:47PM +0000, James Morse wrote:
> +functions_to_move = [
> +	# common
> +	"pr_fmt",
> +
> +	# ctrlmon.c
> +	"rdt_parse_data",
> +	"(ctrlval_parser_t)",
> +	"bw_validate",
> +	"parse_bw",
> +	"cbm_validate",
> +	"parse_cbm",
> +	"get_parser",
> +	"parse_line",
> +	"rdtgroup_parse_resource",
> +	"rdtgroup_schemata_write",
> +	"show_doms",
> +	"rdtgroup_schemata_show",
> +	"smp_mon_event_count",
> +	"mon_event_read",
> +	"rdtgroup_mondata_show",
> +
> +	# internal.h
> +	"MBM_OVERFLOW_INTERVAL",
> +	"CQM_LIMBOCHECK_INTERVAL",
> +	"cpumask_any_housekeeping",
> +	"rdt_fs_context",
> +	"rdt_fc2context",
> +	"mon_evt",
> +	"mon_data_bits",
> +	"rmid_read",
> +	"resctrl_schema_all",
> +	"resctrl_mounted",
> +	"rdt_group_type",
> +	"rdtgrp_mode",
> +	"mongroup",
> +	"rdtgroup",
> +	"RFTYPE_FLAGS_CPUS_LIST",

Something goes wrong with moving the RFTYPE_* defines. A new copy
shows up in fs/resctrl/internal.h but the old copy isn't removed from
arch/x86/kernel/cpu/resctrl/internal.h

-Tony