[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241008234422.5274-1-everestkc@everestkc.com.np>
Date: Tue, 8 Oct 2024 17:44:20 -0600
From: "Everest K.C." <everestkc@...restkc.com.np>
To: oder_chiou@...ltek.com,
lgirdwood@...il.com,
broonie@...nel.org,
perex@...ex.cz,
tiwai@...e.com
Cc: "Everest K.C." <everestkc@...restkc.com.np>,
skhan@...uxfoundation.org,
linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH-next V2] ASoC: rt721-sdca: Clean logically deadcode in rt721-sdca.c
As the same condition was checked in inner and outer if
statements. The code never reaches the inner else statement.
This issue was reported by Coverity Scan with CID = 1600271.
Signed-off-by: Everest K.C. <everestkc@...restkc.com.np>
---
V1 -> V2: - Updated the patch prefix to PATCH-next
- Added how the issue was discovered
sound/soc/codecs/rt721-sdca.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/rt721-sdca.c b/sound/soc/codecs/rt721-sdca.c
index 36056cb7a3ca..4fd26e490610 100644
--- a/sound/soc/codecs/rt721-sdca.c
+++ b/sound/soc/codecs/rt721-sdca.c
@@ -611,13 +611,9 @@ static int rt721_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol,
if (!adc_vol_flag) /* boost gain */
ctl = regvalue / boost_step;
- else { /* ADC gain */
- if (adc_vol_flag)
- ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset);
- else
- ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);
- }
-
+ else /* ADC gain */
+ ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset);
+
ucontrol->value.integer.value[i] = ctl;
}
--
2.43.0
Powered by blists - more mailing lists