linux-kernel - Re: [PATCH 1/1] riscv: sophgo: dts: add power key for pioneer box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aixuis25v56xwnc6zd2ost5yhho5soznpa2pf6fya6orvwwke4@6n3nhzrd7kio>
Date: Tue, 8 Oct 2024 13:18:46 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Chen Wang <unicornxw@...il.com>, aou@...s.berkeley.edu, 
	unicorn_wang@...look.com, conor+dt@...nel.org, guoren@...nel.org, inochiama@...look.com, 
	krzk+dt@...nel.org, palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, 
	chunzhi.lin@...hgo.com
Cc: Inochi Amaoto <inochiama@...il.com>
Subject: Re: [PATCH 1/1] riscv: sophgo: dts: add power key for pioneer box

On Tue, Oct 08, 2024 at 09:43:52AM +0800, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@...look.com>
> 
> There is a power button on the front panel of the pioneer box.
> Short pressing the button will trigger the onboard MCU to
> notify SG2042 through GPIO22 to enter the power-off process.
> 
> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
> ---
>  .../boot/dts/sophgo/sg2042-milkv-pioneer.dts      | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> index a3f9d6f22566..be596d01ff8d 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts
> @@ -5,6 +5,9 @@
>  
>  #include "sg2042.dtsi"
>  
> +#include <dt-bindings/gpio/gpio.h>

Just move this include into sg204.dtsi. It seems you forgot to
add include when sumbitting GPIO dt patch.

> +#include <dt-bindings/input/input.h>
> +
>  / {
>  	model = "Milk-V Pioneer";
>  	compatible = "milkv,pioneer", "sophgo,sg2042";
> @@ -12,6 +15,18 @@ / {
>  	chosen {
>  		stdout-path = "serial0";
>  	};
> +
> +	gpio-power {
> +		compatible = "gpio-keys";
> +
> +		key-power {
> +			label = "Power Key";
> +			linux,code = <KEY_POWER>;
> +			gpios = <&port0a 22 GPIO_ACTIVE_HIGH>;
> +			linux,input-type = <EV_KEY>;
> +			debounce-interval = <100>;
> +		};
> +	};
>  };
>  
>  &cgi_main {
> -- 
> 2.34.1
>